Invert slider movement when up/down arrows are pressed. Fixes #261

doc/changelog.md

@@ -2,6 +2,7 @@
 
 ## changes in this version
 
+* The volume slider, located in the account settings of TWBlue, now should decrease and increase value properly when up and down arrows are pressed. Before it was doing it in inverted order. ([#261](https://github.com/manuelcortez/TWBlue/issues/261))
 * autoreading has been redesigned to work in a similar way for almost all buffers. Needs testing. ([#221](https://github.com/manuelcortez/TWBlue/issues/221))
 * When displaying tweets or direct messages, a new field has been added to show the date when the item has been posted to Twitter.
 * Added support for deleting direct messages by using the new Twitter API methods.

src/wxUI/dialogs/configuration.py

@@ -4,6 +4,7 @@ import wx
 import application
 import output
 import config
+import widgetUtils
 import baseDialog
 from multiplatform_widgets import widgets
 
@@ -268,6 +269,9 @@ class sound(wx.Panel):
   sizer = wx.BoxSizer(wx.VERTICAL)
   volume = wx.StaticText(self, -1, _(u"Volume"))
   self.volumeCtrl = wx.Slider(self)
+  # Connect a key handler here to handle volume slider being inverted when moving with up and down arrows.
+  # see https://github.com/manuelcortez/TWBlue/issues/261
+  widgetUtils.connect_event(self.volumeCtrl, widgetUtils.KEYPRESS, self.on_keypress)
   self.volumeCtrl.SetRange(0, 100)
   self.volumeCtrl.SetSize(self.volumeCtrl.GetBestSize())
   volumeBox = wx.BoxSizer(wx.HORIZONTAL)
@@ -305,6 +309,18 @@ class sound(wx.Panel):
   sizer.Add(self.indicate_img, 0, wx.ALL, 5)
   self.SetSizer(sizer)
 
+ def on_keypress(self, event, *args, **kwargs):
+  """ Invert movement of up and down arrow keys when dealing with a wX Slider.
+  See https://github.com/manuelcortez/TWBlue/issues/261
+  and http://trac.wxwidgets.org/ticket/2068
+  """
+  keycode = event.GetKeyCode()
+  if keycode == wx.WXK_UP:
+   return self.volumeCtrl.SetValue(self.volumeCtrl.GetValue()+1)
+  elif keycode == wx.WXK_DOWN:
+   return self.volumeCtrl.SetValue(self.volumeCtrl.GetValue()-1)
+  event.Skip()
+
  def get(self, control):
   return getattr(self, control).GetStringSelection()